Skip to content

BL-15694 Support navigation links on blorg#609

Open
nabalone wants to merge 1 commit intomasterfrom
BL-15694_support_navigation_links_on_blorg
Open

BL-15694 Support navigation links on blorg#609
nabalone wants to merge 1 commit intomasterfrom
BL-15694_support_navigation_links_on_blorg

Conversation

@nabalone
Copy link
Contributor

@nabalone nabalone commented Mar 24, 2026

This PR addresses the issue BL-15694 by adding support for navigation links on blorg.


Open with Devin

This change is Reviewable

@nabalone nabalone force-pushed the BL-15694_support_navigation_links_on_blorg branch from ba6f6e7 to 627e97c Compare March 24, 2026 20:59
Copy link
Contributor

@JohnThomson JohnThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is hard to review. A lot of code moved and it's not clear whether it changed significantly or just got refactored. Also, a lot of the code feels 'magical', since I know little about service workers. Probably a lot of it was CoPilot. I've gone on the principle that since it works and seems vaguely reasonable, it's probably OK. It's all only going to affect books with this new feature, and we can quickly deploy a fix to Blorg if we need to. I picked up a couple of minor things. If there's anything you think I should particularly pay attention to, please point it out.

@JohnThomson reviewed 3 files and all commit messages, and made 3 comments.
Reviewable status: 3 of 11 files reviewed, 2 unresolved discussions (waiting on nabalone).


src/book-navigation-interceptor-sw.js line 127 at r1 (raw file):

    const data = await response.json();
    return data.results?.[0];

Between this and the limit: "1" above, it seems you decided to ignore the possibility that there is more than one matching book. I think that's OK...this is a big step forward even without such error handling, and hopefully people who upload linked collections of books know enough to avoid such mistakes, and even if the mistake is made the book it takes you to has some hope of being relevant. Might be worth noting, though, in a comment.


src/model/BookUrlUtils.ts line 46 at r1 (raw file):

    filePath: string
): string | undefined {
    // TODO update comment

Looks like this still needs attention

Copy link
Contributor

@JohnThomson JohnThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JohnThomson reviewed 8 files.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on nabalone).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants