Skip to content

Take action button#475

Open
AnsonLee99 wants to merge 3 commits intomasterfrom
take-action-button
Open

Take action button#475
AnsonLee99 wants to merge 3 commits intomasterfrom
take-action-button

Conversation

@AnsonLee99
Copy link
Contributor

@AnsonLee99 AnsonLee99 commented May 26, 2020

Implemented the take-action button on the feed screen. Tapping this button will reveal a dropdown for specific skill requests and project goals from the campaign. Currently, the "apply" button's funcitonality is not fully implemented and the take-action button can be further expanded to support donations and in-person help.

Checklist

Remove any items which are not applicable.

  • I have performed a self-review of my own code.
  • I have added tests that prove my fix is effective or that my feature works AND the tests pass.

Copy link
Contributor

@typokign typokign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, styling is a bit off:

  • Take Action button should be white (see XD)
  • Not sure where you got the "What we need help with" action, it's nice but IMO takes up too much room for not much benefit. Maybe remove it for now, and in the future we might make it pop up the first time you click Take Action?
  • "Skills needed for this campaign are" should be lighter gray
  • Not a big fan of having to tap "Give Skills" and then a skill to be able to see the goals/apply button. I think the mockup is pretty good UX
  • More separators maybe? I like that we're keeping everything in one card but there should still be some distinction between the post body and the actions
  • Skill bubbles should be solid green as shown in the mockup
  • Maybe the Take Action button should collapse the section when tapped again?

image

<TouchableOpacity
style={ styles.buttonTouch }
onPress={() => {
// TODO: Handle application process
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we show a quick toast or something that says "Coming Soon"? Don't want the UX to be confusing if we have to release before the application page is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants