Open
Conversation
typokign
suggested changes
May 26, 2020
Contributor
typokign
left a comment
There was a problem hiding this comment.
Code looks good, styling is a bit off:
- Take Action button should be white (see XD)
- Not sure where you got the "What we need help with" action, it's nice but IMO takes up too much room for not much benefit. Maybe remove it for now, and in the future we might make it pop up the first time you click Take Action?
- "Skills needed for this campaign are" should be lighter gray
- Not a big fan of having to tap "Give Skills" and then a skill to be able to see the goals/apply button. I think the mockup is pretty good UX
- More separators maybe? I like that we're keeping everything in one card but there should still be some distinction between the post body and the actions
- Skill bubbles should be solid green as shown in the mockup
- Maybe the Take Action button should collapse the section when tapped again?
typokign
reviewed
May 26, 2020
| <TouchableOpacity | ||
| style={ styles.buttonTouch } | ||
| onPress={() => { | ||
| // TODO: Handle application process |
Contributor
There was a problem hiding this comment.
Can we show a quick toast or something that says "Coming Soon"? Don't want the UX to be confusing if we have to release before the application page is done.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Implemented the take-action button on the feed screen. Tapping this button will reveal a dropdown for specific skill requests and project goals from the campaign. Currently, the "apply" button's funcitonality is not fully implemented and the take-action button can be further expanded to support donations and in-person help.
Checklist
Remove any items which are not applicable.