Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the thick fog in all dimensions to behave like the thin fog present in the Xbox 360 version of the game.
Changes
Previous Behavior
The fog was thick across all dimensions.
Root Cause
Flaw in the original game code which creates thicker fog at lower render distances. Existed in the original source code but was not noticeable until upstream maintainers added the render distance options.
New Behavior
The fog now matches the thickness of fog present in the original 360 version.
Fix Implementation
This was fixed by locating values that handle fog rendering then putting breakpoints on the game to test new values until a close match to the Xbox 360 version was found.
AI Use Disclosure
AI was not used at any point in this PR.
Related Issues
Fixes an issue presented on the discord; not sure the preferred way to link this issue.
Screenshots
Pre-fix: thick layer of fog
Post-fix: thin layer of fog