Merged
Conversation
Render distance being high causes issues with fog, 360 fog levels are not built for high render distance. When fog is fixed in future PR, render distance should be re-enabled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR exposes the customization of the FOV through a launch option. A render distance option also exists in this code, it was explicitly disabled due to conflicts with the 360 fog.
Changes
Previous Behavior
The FOV was not customizable.
Root Cause
The FOV slider in the gui was removed for parity with the 360 edition.
New Behavior
The game now treats FOV as a launch option, this adds back customization without breaking parity.
Fix Implementation
The fix was created by modifying the launch argument handler to save any FOV or render distance arguments, then to load them into the options.txt, and set them every time the game starts.
AI Use Disclosure
AI was not used at any point in this PR.
Screenshots
FOV: 110 (Wiiide)
FOV: 70 (Default)