Skip to content
This repository was archived by the owner on Feb 26, 2025. It is now read-only.

Conversation

@AurelienJaquier
Copy link
Collaborator

@AurelienJaquier AurelienJaquier commented Jan 10, 2025

Allows to skip threshold computation during analysis to save a little bit of CPU time.

  • ability to store rmp, rin, holding current and threshold current in EModel object
  • store them during validation
  • ability to skip threshold computation if rmp, rin, holding current and threshold current are given to ProtocolRunner
  • give rmp, rin, holding current and threshold current to ProtocolRunner during compute_responses()

@AurelienJaquier AurelienJaquier self-assigned this Jan 10, 2025
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 68.75000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 51.29%. Comparing base (8d5b0ab) to head (098dd56).
Report is 135 commits behind head on main.

Files with missing lines Patch % Lines
bluepyemodel/evaluation/protocols.py 60.00% 4 Missing ⚠️
bluepyemodel/evaluation/evaluation.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #181      +/-   ##
==========================================
- Coverage   60.07%   51.29%   -8.79%     
==========================================
  Files         109      125      +16     
  Lines        7838    10744    +2906     
==========================================
+ Hits         4709     5511     +802     
- Misses       3129     5233    +2104     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ilkilic ilkilic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you

@AurelienJaquier AurelienJaquier merged commit e127613 into main Jan 13, 2025
6 checks passed
@AurelienJaquier AurelienJaquier deleted the store-threshold-data branch January 13, 2025 08:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants