This repository was archived by the owner on Jun 15, 2024. It is now read-only.
Refactored and Documented init.gd and boot.tscn#7
Open
Jazztache wants to merge 1 commit intoBlueboxTeam:masterfrom
Open
Refactored and Documented init.gd and boot.tscn#7Jazztache wants to merge 1 commit intoBlueboxTeam:masterfrom
Jazztache wants to merge 1 commit intoBlueboxTeam:masterfrom
Conversation
I went through and refactored some of the init.gd code to be cleaner, as well as use proper variable references. I did the same with the scene itself, renaming things to be clearer. The only major code changes was the extra loop, and some dummy comments I decided to remove. main.gd also got a bit of documentation as well.
Author
|
I also built it with the prebuilt winter.so file on the Winter repo on Arch Linux. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I went through and refactored some of the init.gd code to be cleaner, as well as use proper variable references. I did the same with the scene itself, renaming things to be clearer. The only major code changes was the extra loop, and some dummy comments I decided to remove. main.gd also got a bit of documentation as well.