Open
Conversation
…ns its action bar on/off
…addendum: oops, didn't fix the case when a new opener is created and dropped onto an already occupied btn slot
…ry action bar vanish - REVAMP! Found a much better way involving setting the opener Frame's parent. Also, shrank the code a lot. For issue Boboseb#9, I ask the bar object itself for the correct direction.
Author
|
this PR also fixes #10 for the new Dragonflight bars |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a fix for the bug I just opened... and all of my earlier fixes too because I branched off my fixes branch and not your master OOPS. If you need me to tease them apart and resubit, please let me know. Otherwise, accepting this PR will bring in all of my fixes so far.