Skip to content

android support (tested with yadaw)#174

Merged
Boddlnagg merged 3 commits intoBoddlnagg:masterfrom
mlm-games:android-support
Nov 3, 2025
Merged

android support (tested with yadaw)#174
Boddlnagg merged 3 commits intoBoddlnagg:masterfrom
mlm-games:android-support

Conversation

@mlm-games
Copy link
Contributor

Adds android support, tested using yadaw

More info (pasted from readme)

  • Requires Android API 29+ and the Android NDK (r20b+).
  • Build example:
    • Install: cargo install cargo-ndk
    • Targets: rustup target add aarch64-linux-android
    • Build: cargo ndk -t arm64-v8a -o ./app/src/main/jniLibs build --release
  • Permissions/features:
    • Manifest should declare <uses-feature android:name="android.software.midi" android:required="false" /> (not needed for USB/BLE MIDI).

Copy link
Owner

@Boddlnagg Boddlnagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR! Android support is very valuable for this project, and something I would never have found time to work on myself :-)

I'm not really able to review this in-depth or test this (I have never done any Android development), but I trust that you have tested it.
It would be great if you could find some way to test/build this on CI ... is there any way to achieve that (either through the existing Azure Pipelines, or with GitHub Actions)?

@mlm-games
Copy link
Contributor Author

mlm-games commented Oct 16, 2025

It would be great if you could find some way to test/build this on CI ... is there any way to achieve that (either through the existing Azure Pipelines, or with GitHub Actions)?

Actually had looked at #77 previously, was interested in trying to migrate it to gh actions for the current ones (am familiar with it too). Might just open another pr or commit the yml changes here soon..

@mlm-games mlm-games force-pushed the android-support branch 2 times, most recently from 937cb72 to afb416e Compare October 17, 2025 01:43
@Boddlnagg Boddlnagg added this to the 0.11.0 milestone Oct 18, 2025
@Boddlnagg
Copy link
Owner

Thanks for your work on the GH actions migration!
But now I'm not sure about the state of this PR ... is it ready to be reviewed?

@mlm-games
Copy link
Contributor Author

mlm-games commented Oct 30, 2025

Yep, its ready to be reviewed

@Boddlnagg
Copy link
Owner

Is it too much to ask that you extract the migration to GitHub Actions into a separate PR, which can be merged first independently?

@mlm-games
Copy link
Contributor Author

mlm-games commented Nov 2, 2025

Oh, thought it wasn't asked before, will do it by tomorrow.

@mlm-games
Copy link
Contributor Author

Done

@Boddlnagg
Copy link
Owner

Boddlnagg commented Nov 2, 2025

You can now rebase on top of master and enable the line in ci.yml that I commented out.

@mlm-games
Copy link
Contributor Author

mlm-games commented Nov 3, 2025

You can now rebase on top of master and enable the line in ci.yml that I commented out.

done

@Boddlnagg Boddlnagg merged commit 57d17bd into Boddlnagg:master Nov 3, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants