This repository was archived by the owner on Feb 29, 2024. It is now read-only.
Redirect all zuul web requests to the app #385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zuul V3 has tenant names in the URLs so they are much more variable. This means that we can't simply rely on hardcoding a couple of paths into our apache config and we should probably just forward everything to the zuul app. Signed-off-by: Jamie Lennox <jamielennox@gmail.com>
Contributor
|
Doesn't this mean that we will no longer be serving /opt/source/zuul/etc/status/public_html/ and so no longer serving the website displaying the states of the pipeline queues? If so, should we create a new vhost to serve that public_html directory so that we can still have a website showing the states of the pipeline queues? |
Contributor
|
I think the web app itself takes care of the pipeline states. |
Contributor
Author
|
I... don't know. The webapp is broken on v3 so i haven't been able to check. Is there a way we can prioritize serving the static files? |
Contributor
|
It looks like rewrite rules allow for PCRE, so we can glob the tenant portion similar to how we glob the current status rewrite. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zuul V3 has tenant names in the URLs so they are much more variable.
This means that we can't simply rely on hardcoding a couple of paths
into our apache config and we should probably just forward everything to
the zuul app.
Signed-off-by: Jamie Lennox jamielennox@gmail.com