Open
Conversation
The internal buffers are only pulled out when they're actually needed, some of the if statements were rearranged, and added a Merge function to see which parts of the code are duplicated. This will obviously be cleaned up a lot before release.
The C version was really slow with the old design, so I changed the in-place merge to use three separate steps: merge subarrays that are already in order or reverse order, extract the buffers if needed, and merge the remaining subarrays.
Uses the new design from the C++ version, which is a lot faster for certain data arrangements and no slower overall
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.