Skip to content

Feature: #3109 - Add F2/Delete hotkeys in HostsFileEditor & Refactor #3113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 22, 2025

Conversation

BornToBeRoot
Copy link
Owner

Changes proposed in this pull request

  • Add F2/Delete hotkeys in HostsFileEditor
  • Refactor some code

Related issue(s)

Copilot generated summary

Provide a Copilot generated summary of the changes in this pull request.

Copilot summary

This pull request introduces several improvements to the NETworkManager project, focusing on enhancing user interface interactions, improving command execution patterns, and ensuring better accessibility by setting focus on specific UI elements when child windows are loaded. Below is a summary of the most important changes grouped by theme:

Enhanced User Interface Interactions:

Improved Command Execution Patterns:

Accessibility Improvements in Child Windows:

  • Added focus logic to specific UI elements when child windows are loaded to improve accessibility and user experience:
    • Source/NETworkManager/Views/OKMessageChildWindow.xaml and OKMessageChildWindow.xaml.cs: Focuses the OK button when loaded. [1] [2]
    • Similar focus improvements in UpgradeChildWindow, WelcomeChildWindow, and OKCancelInfoMessageChildWindow. [1] [2] [3] [4] [5]

Code Cleanup:

  • Removed unnecessary comments and redundant using directives across several files to improve code readability and maintainability:
    • Source/NETworkManager/Views/DNSLookupSettingsView.xaml.cs and HostsFileEditorView.xaml.cs. [1] [2]

These changes collectively enhance the user experience, improve code quality, and ensure better adherence to UI and accessibility standards.

To-Do

Contributing

By submitting this pull request, I confirm the following:

@BornToBeRoot BornToBeRoot added this to the next-release milestone Jul 22, 2025
@mergify mergify bot merged commit 85cb4d7 into main Jul 22, 2025
4 checks passed
@mergify mergify bot deleted the feature/3109 branch July 22, 2025 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HostsFileEditor - Add F2/double click to edit entry
1 participant