Skip to content

Feature: Hide IPv4/6, DNS and DHCP info if adapter is down #3114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 23, 2025
Merged

Conversation

BornToBeRoot
Copy link
Owner

Changes proposed in this pull request

  • Hide IPv4/6, DNS and DHCP info if adapter is down

Related issue(s)

Copilot generated summary

Provide a Copilot generated summary of the changes in this pull request.

Copilot summary

This pull request introduces new converters for handling visibility logic based on boolean values, refactors existing converters for clarity, and improves code readability in the GetNetworkInterfaces method. Additionally, it updates XAML files to utilize the new converters.

Converter Enhancements:

  • Added BooleansAndToVisibilityCollapsedConverter to handle visibility logic where all boolean values must be true for visibility. (Source/NETworkManager.Converters/BooleansAndToVisibilityCollapsedConverter.cs, Source/NETworkManager.Converters/BooleansAndToVisibilityCollapsedConverter.csR1-R20)
  • Renamed BooleanToVisibilityCollapsedMultiConverter to BooleansOrToVisibilityCollapsedConverter for clarity and updated its usage in XAML files. (Source/NETworkManager.Converters/BooleansOrToVisibilityCollapsedConverter.cs, [1]; Source/NETworkManager/Views/IPScannerView.xaml, [2] [3] [4] [5]

Code Readability Improvements:

  • Added missing braces {} in the GetNetworkInterfaces method to improve readability and maintain consistency. (Source/NETworkManager.Models/Network/NetworkInterface.cs, [1] [2] [3]

XAML Updates:

To-Do

Contributing

By submitting this pull request, I confirm the following:

@mergify mergify bot merged commit 4b07dd9 into main Jul 23, 2025
4 checks passed
@mergify mergify bot deleted the feature/3111 branch July 23, 2025 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wireless adapter disabled in windows 11, but shown with an assigned IP address
1 participant