Modify cursor.fetchmany() to break after no results#62
Open
mkmoisen wants to merge 1 commit intoBradRuderman:masterfrom
Open
Modify cursor.fetchmany() to break after no results#62mkmoisen wants to merge 1 commit intoBradRuderman:masterfrom
mkmoisen wants to merge 1 commit intoBradRuderman:masterfrom
Conversation
Currently, if you call `cur.fetchmany(1000)` while there is only 1 row left to fetch, the loop will call `self.fetchone()` 1000 times and will return an array of size 1000, where 999 values are None. This file change breaks out of the loop if `self.fetchone()` returns None to prevent this behavior, exactly what `fetchall()` does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, if you call
cur.fetchmany(1000)while there is only 1 row left to fetch, the loop will callself.fetchone()1000 times and will return an array of size 1000, where 999 values are None.This file change breaks out of the loop if
self.fetchone()returns None to prevent this behavior, exactly whatfetchall()does.