feat :: [124] queryUserSimpleInfo 추가 #125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
""" Walkthrough이 변경사항은 기존의 Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant UserController
participant QueryUserSimpleInfoUseCase
participant QueryUserService
participant S3Util
Client->>UserController: GET /user
UserController->>QueryUserSimpleInfoUseCase: execute()
QueryUserSimpleInfoUseCase->>QueryUserService: getCurrentUser()
QueryUserSimpleInfoUseCase->>S3Util: generateUrl(profile)
QueryUserSimpleInfoUseCase-->>UserController: SimpleInfoResponse(accountId, profileUrl)
UserController-->>Client: SimpleInfoResponse(accountId, profileUrl)
Assessment against linked issues
Assessment against linked issues: Out-of-scope changes(해당 변경사항에서는 명확하게 범위를 벗어난 코드 변경이 발견되지 않았으므로 이 섹션은 생략합니다.) Possibly related PRs
Poem
""" 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (1)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (2)
src/main/kotlin/dsm/wemeet/domain/user/presentation/UserController.kt (2)
38-38: 생성자 파라미터명의 오타를 수정해주세요.
queyUserSimpleInfoUseCase는queryUserSimpleInfoUseCase로 수정되어야 합니다.다음과 같이 수정하세요:
- private val queyUserSimpleInfoUseCase: QueryUserSimpleInfoUseCase + private val queryUserSimpleInfoUseCase: QueryUserSimpleInfoUseCase
66-66: 메소드에서도 파라미터명 오타를 수정해주세요.생성자 파라미터명 수정에 따라 메소드 내부에서도 동일하게 수정이 필요합니다.
다음과 같이 수정하세요:
- fun getMySimpleInfo() = queyUserSimpleInfoUseCase.execute() + fun getMySimpleInfo() = queryUserSimpleInfoUseCase.execute()
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
src/main/kotlin/dsm/wemeet/domain/user/presentation/UserController.kt(3 hunks)src/main/kotlin/dsm/wemeet/domain/user/presentation/dto/response/AccountIdResponse.kt(0 hunks)src/main/kotlin/dsm/wemeet/domain/user/presentation/dto/response/SimpleInfoResponse.kt(1 hunks)src/main/kotlin/dsm/wemeet/domain/user/usecase/QueryAccountIdUseCase.kt(0 hunks)src/main/kotlin/dsm/wemeet/domain/user/usecase/QueryUserSimpleInfoUseCase.kt(1 hunks)
💤 Files with no reviewable changes (2)
- src/main/kotlin/dsm/wemeet/domain/user/presentation/dto/response/AccountIdResponse.kt
- src/main/kotlin/dsm/wemeet/domain/user/usecase/QueryAccountIdUseCase.kt
🔇 Additional comments (6)
src/main/kotlin/dsm/wemeet/domain/user/presentation/dto/response/SimpleInfoResponse.kt (2)
3-6: 구현이 깔끔하고 적절합니다.데이터 클래스 구조가 간단하고 명확하며, 네이밍 컨벤션도 잘 지켜졌습니다. 프로필 필드가 nullable로 설정된 것도 선택적 프로필 URL에 적합합니다.
3-6: 깔끔한 DTO 구조입니다.간단하고 명확한 데이터 클래스 구조로, nullable profile 필드 처리도 적절합니다.
src/main/kotlin/dsm/wemeet/domain/user/usecase/QueryUserSimpleInfoUseCase.kt (2)
8-21: 잘 구성된 유스케이스 구현입니다.의존성 주입이 올바르게 설정되어 있고, 안전한 호출 연산자(?.let)를 사용하여 nullable 프로필을 적절히 처리했습니다. 클린 아키텍처 원칙을 잘 따르고 있습니다.
14-20: 잘 구현된 유스케이스입니다.null 안전성을 고려한 프로필 URL 생성 로직과 깔끔한 유스케이스 패턴 구현이 좋습니다.
src/main/kotlin/dsm/wemeet/domain/user/presentation/UserController.kt (2)
65-66: 엔드포인트 경로 변경이 적절합니다.기존
/user/accountId에서/user로 변경된 것은 더 간단하고 직관적인 구조입니다. 확장된 사용자 정보를 제공하는 새로운 유스케이스 로직도 잘 구현되었습니다.
65-66: 엔드포인트 변경이 적절합니다.
GET /user/accountId에서GET /user로의 변경이 더 RESTful하고 직관적입니다. 메소드명도 의미에 맞게 잘 변경되었습니다.
src/main/kotlin/dsm/wemeet/domain/user/presentation/UserController.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/dsm/wemeet/domain/user/presentation/UserController.kt
Outdated
Show resolved
Hide resolved
zios0707
approved these changes
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
/user경로에서 계정 ID와 프로필 정보를 함께 확인할 수 있습니다./user/accountId경로는/user로 통합되어 계정 ID만 반환하던 방식에서 계정 ID와 프로필 정보를 함께 반환하도록 변경되었습니다.