Add support folia #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thorinwasher
requested changes
Jul 15, 2025
Collaborator
Thorinwasher
left a comment
Thorinwasher
left a comment
There was a problem hiding this comment.
I get the feeling that more things might break, but I'm honestly not sure
| private void checkAlive(GardenPlant gardenPlant) { | ||
| Bukkit.getScheduler().runTask(Garden.getInstance(), () -> { | ||
| Bukkit.getGlobalRegionScheduler().run(Garden.getInstance(), task -> { | ||
| if (gardenPlant.isAlive()) { |
Collaborator
There was a problem hiding this comment.
This check should be done in the local thread
| this.registerPlantRecipes(); | ||
| this.getLifecycleManager().registerEventHandler(LifecycleEvents.COMMANDS, GardenCommand::register); | ||
| Bukkit.getScheduler().runTaskTimer(this, new GrowthManager(gardenRegistry, gardenPlantDataType)::tick, 0, 200); | ||
| Bukkit.getAsyncScheduler().runAtFixedRate(this, task -> new GrowthManager(gardenRegistry, gardenPlantDataType).tick(), 1L, 200L, TimeUnit.MILLISECONDS); |
Collaborator
There was a problem hiding this comment.
You changed the unit of time here, from ticks to milliseconds
Author
There was a problem hiding this comment.
You changed the unit of time here, from ticks to milliseconds
idk why changed this to async scheduler, if i don't change in past
Author
There was a problem hiding this comment.
You changed the unit of time here, from ticks to milliseconds
oh, this is a garden, I'm sorry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First support for folia in this plugin. There may still be areas that require revision.