Skip to content

Add Aspire to examples #3613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Conversation

holytshirt
Copy link
Member

No description provided.

- Added a new solution file `Brighter.slnx` with multiple project configurations for various samples and tasks.
- Updated package versions in `Directory.Packages.props` to 9.2.1 for `Aspire.Hosting.AppHost` and `Aspire.Hosting.MySql`, and added new dependencies.
- Refactored connection string retrieval in `Extensions.cs` and `Program.cs` for better clarity and consistency.
- Updated project references in `GreetingsWeb.csproj` and `MigrationService.csproj` to ensure proper linking.
- Cleaned up unused package versions and improved project structure in `WebAPI_EFCore` samples.
- Updated `OutboxFactory.cs` to correct the order of parameters in the MySQL outbox creation method.
- Renamed the `Recipient_Id` column to `RecipientId` in the initial migration file for consistency.
- Modified HTTP test scripts to use a base URI variable for cleaner endpoint management.
- Changed the `DbSet` property name from `People` to `Person` in `GreetingsEntityGateway` for clarity.
- Updated various handler classes to reference the new `Person` property instead of `People`.
- Adjusted the greeting creation endpoint to include the person's name in the URL path for better RESTful design.
- Added `Aspire.Hosting.RabbitMQ` package version 9.2.1 to `Directory.Packages.props`.
- Updated `Program.cs` to include RabbitMQ configuration and reference in the project setup.
- Modified project file `WebAPI_EFCore.AppHost.csproj` to include RabbitMQ as a package reference.
@holytshirt holytshirt linked an issue May 18, 2025 that may be closed by this pull request
Copy link

@codescene-delta-analysis codescene-delta-analysis bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gates Passed
6 Quality Gates Passed

See analysis details in CodeScene

Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.

@@ -49,11 +54,14 @@
<PackageVersion Include="Microsoft.Extensions.Hosting" Version="9.0.4" />
<PackageVersion Include="Microsoft.Extensions.Hosting.Abstractions" Version="9.0.4" />
<PackageVersion Include="Microsoft.Extensions.Http" Version="9.0.4" />
<PackageVeroisn Include="Microsoft.Extensions.Http.Resilience" Version="9.4.0" />
<PackageVersion Include="Microsoft.Extensions.Http.Resilience" Version="9.4.0" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<PackageVersion Include="Microsoft.Extensions.Http.Resilience" Version="9.4.0" />

Looks like this line got doubled up

@iancooper iancooper added the RC2 label May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Support Aspire
3 participants