Skip to content

[MA-17]: Added aria-activedescendant to the textbox#31

Open
ayush-chauhan233 wants to merge 2 commits intomasterfrom
ma_17/issue_mm_61610
Open

[MA-17]: Added aria-activedescendant to the textbox#31
ayush-chauhan233 wants to merge 2 commits intomasterfrom
ma_17/issue_mm_61610

Conversation

@ayush-chauhan233
Copy link

@ayush-chauhan233 ayush-chauhan233 commented Dec 23, 2024

Summary

  • Added aria-activedescendant to the textbox.
  • Added role option to the suggested list item.

Steps to reproduce

  • Navigate to the write to town square edit field and type '@'.
  • Now navigate to the suggestion list using down arrow key.
  • Notice that the suggestion list elements are not announced by the screen reader.

Expected Behavior

  • The screen reader should announce the selected to keyboard interacted suggested item correctly.

Note: Due to the structure of the component, we couldn't comply with the accessibility requirements of grouping the list.

Ticket Link

Jira https://mattermost.atlassian.net/browse/MM-61610

Screenshots

Before After

Release Note

NONE

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can use id directly instead of passing as props

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
aria-owns='suggestionList'
aria-controls='suggestionList'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants