Merged
Conversation
The issue was that formUrl() method was being called on every Angular change detection cycle (triggered by scrolling). This caused the sanitizer to create a new object reference each time, which Angular interpreted as a change, causing the iframe to reload. Solution: Compute and sanitize the URL once in ngOnInit() and store it in a property. The template now binds directly to the property instead of calling a method, preventing unnecessary re-renders. Co-authored-by: AlaqmarG <117380848+AlaqmarG@users.noreply.github.com>
…ms-refresh Fix embedded Google forms refreshing on scroll
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes 🛠
What does this PR do?
#183
Screenshots 🖼
Before
After
Any new npm dependencies?
NO
Testing 🧪
Changes from the latest PR are deployed to https://brockcsc-pr.web.app once the checks are complete. Can use this for testing.
Any other info needed for testing?
NO