Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves how course colors are initialized and managed in the course list components. The main focus is to ensure that every course gets a color assigned as soon as it appears, and that color assignment is consistent and avoids color conflicts. The changes also make the color assignment logic more robust by using React hooks and references to keep state updates in sync.
Improvements to course color initialization and assignment:
initializeCourseColorfunction inCourseColorsContextto explicitly assign a color to a course if it doesn't already have one, and updatedCourseListItemComponentto call this function when a new course appears.usedColorsRefreference to always have the latest state, preventing stale state issues when determining available colors.General code improvements:
useEffect,useCallback) in bothCourseListItemComponent.jsxandCourseColorsContext.jsx.initializeCourseColorfunction to consumers.These changes make color assignment more reliable and ensure that UI components always display courses with assigned, non-conflicting colors.