fix: defer calendar navigation render warning#76
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addresses a React warning related to calling
gotoDateon the calendar API during the render phase. The main improvement is deferring these calls usingqueueMicrotaskto ensure they occur outside of React's synchronous rendering, preventing potential issues and warnings.Improvements to calendar navigation logic:
calendarApi.gotoDateis called to defer execution usingqueueMicrotask, avoiding flushSync warnings during React render.calendarRef.currentand its API to prevent runtime errors when the reference is not available. (src/components/generator/Calendar/CalendarComponent.jsx)