Skip to content
This repository was archived by the owner on Aug 15, 2023. It is now read-only.

fix for flickering when typing fast#5

Open
leafnode wants to merge 1 commit intoBuddyMeme:masterfrom
leafnode:master
Open

fix for flickering when typing fast#5
leafnode wants to merge 1 commit intoBuddyMeme:masterfrom
leafnode:master

Conversation

@leafnode
Copy link

When typing fast the image flickers. I found out that it's due to setting canvas width/height each time, even if it's not necessary. Fix for this is to set canvas dimensions only if its current size is different from the image data.

@ludar
Copy link

ludar commented Dec 5, 2013

Thanks for trying to fix it but i still get image flicker with every new typed letter.

@leafnode
Copy link
Author

leafnode commented Dec 5, 2013

Yeah, I noticed that too. I'll try to work on that issue further.

On 5 gru 2013, at 19:35, ludar notifications@github.com wrote:

Thanks for trying to fix it but i still get image flicker with every new typed letter.


Reply to this email directly or view it on GitHub.

@ludar
Copy link

ludar commented Dec 5, 2013

Its mentioned in issue #4 and issues #1

and seems to be fixed here
albertein@7a93554

@leafnode
Copy link
Author

leafnode commented Dec 5, 2013

Nope, albertein's fork is affected by the same problem as the original code - I've just tested it.
Test video: http://www.screencast.com/t/wnrRztJPf

@albertein
Copy link

@leafnode are you sure you tested it on layered_meme_canvas branch?, master is just a direct copy of upstream.

@ludar
Copy link

ludar commented Dec 5, 2013

I can confirm @albertein that it works

@leafnode
Copy link
Author

leafnode commented Dec 6, 2013

Whoops, I didn't notice that the change was on a branch. Unfortunately on the computer I'm using now I see no flickering at all - I'll verify that in the evening. Thanks for pointing that out.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants