Skip to content

Conversation

@mikaalnaik
Copy link
Collaborator

No description provided.

@sprice sprice self-requested a review October 3, 2025 16:27
@sprice
Copy link
Member

sprice commented Oct 3, 2025

@mikaalnaik can you please describe what stale data issue you were seeing?

I see the changes enable ISR (switching from force-dynamic to auto) and reduce revalidation to 2 minutes, but I think there's a remaining cache misalignment:

src/app/page.tsx

  • L13: export const revalidate = 120; // 2 minutes (ISR)
  • L149: const ttlMs = 300 * 1000; // 5 minutes (in-memory cache)

This means DB updates (bill analysis etc) could still take up to 5 minutes to appear on the home page. Should line 149 also use REVALIDATE_INTERVAL * 1000?

@sprice sprice merged commit 29286b6 into main Oct 16, 2025
1 check passed
Copy link
Member

@sprice sprice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants