Added support for attributes on function arguments #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, block_var attributes through metadata could be added to only local variables. This change fixes the c code generator to also print the attributes on function parameters.
However, there was a critical issue in how the arguments were created. The signature_extract creates a var to be added to the function signature but initializes the actual argument using with_name. This creates an entirely different var which doesn't share metadata with the parameter added to the func_decl. To fix this we added a new constructor helper for dyn_var namely with_block_var which creates a dyn_var by reusing an existing block_var. Now signature_extract uses this to initialize the argument unifying the two arguments and allowing users to set attributes on the variables.
A new add_attribute function has been added to simplify managing attributes. Sample 69 has been added to test this.