Skip to content

feat: typescript compilation check on CI #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
harshtandiya wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

feat: typescript compilation check on CI #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a8157df
feat: add TypeScript type checking and skip library check
harshtandiya Feb 8, 2026
f6f9118
feat: add TypeScript type checking workflow for frontend
harshtandiya Feb 8, 2026
48a59a9
chore: update typecheck workflow paths and working directories
harshtandiya Feb 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 41 additions & 0 deletions .github/workflows/typecheck.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
name: Frontend TypeScript

on:
push:
branches:
- develop
paths:
- "frontend/**"
- ".github/workflows/typecheck.yml"
pull_request:
paths:
- "frontend/**"
- ".github/workflows/typecheck.yml"

concurrency:
group: typecheck-forms_pro-${{ github.event.number || github.sha }}
cancel-in-progress: true

jobs:
typecheck:
name: TypeScript
runs-on: ubuntu-latest

steps:
- name: Checkout
uses: actions/checkout@v4

- name: Setup Node
uses: actions/setup-node@v4
with:
node-version: "24"
cache: "yarn"
cache-dependency-path: frontend/yarn.lock

- name: Install dependencies
working-directory: frontend
run: yarn install --frozen-lockfile

- name: Type check
working-directory: frontend
run: yarn typecheck
1 change: 1 addition & 0 deletions frontend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
"build": "vite build --base=/assets/forms_pro/frontend/ && yarn copy-html-entry",
"preview": "vite preview",
"lint": "biome check --write .",
"typecheck": "tsc --noEmit",
"copy-html-entry": "cp ../forms_pro/public/frontend/index.html ../forms_pro/www/forms.html"
},
"dependencies": {
Expand Down
1 change: 1 addition & 0 deletions frontend/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
"@/*": ["src/*"]
}
},
"skipLibCheck": true,
Copy link

@coderabbitai coderabbitai bot Feb 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Top-level skipLibCheck is not a valid tsconfig property — it has no effect.

skipLibCheck is only recognized inside compilerOptions (already set at line 7). Placing it at the root level is silently ignored by TypeScript. This line should be removed.

Proposed fix 
   },
-  "skipLibCheck": true,
   "include": ["src/**/*.ts", "src/**/*.d.ts", "src/**/*.tsx", "src/**/*.vue", "src/main.ts"],
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"skipLibCheck": true,
},
"include": ["src/**/*.ts", "src/**/*.d.ts", "src/**/*.tsx", "src/**/*.vue", "src/main.ts"],
🤖 Prompt for AI Agents 
In `@frontend/tsconfig.json` at line 23, The tsconfig contains a stray top-level
"skipLibCheck" property that is ignored; remove the top-level "skipLibCheck"
entry and ensure the existing compilerOptions.skipLibCheck value (in the
"compilerOptions" object) is the single source of truth; locate the top-level
"skipLibCheck" key and delete it so only "compilerOptions.skipLibCheck" remains.

"include": ["src/**/*.ts", "src/**/*.d.ts", "src/**/*.tsx", "src/**/*.vue", "src/main.ts"],
"references": [{ "path": "./tsconfig.node.json" }]
}
Loading