Proposal: Add Optional Elements to All Assets #515
Conversation
markborkum
added
Schema: General
BuildingSync.xsd
Outdated
| </xs:element> | ||
| <xs:element ref="auc:LinkedPremises" minOccurs="0"/> | ||
| <xs:element ref="auc:UserDefinedFields" minOccurs="0"/> | ||
| <xs:element name="AirInfiltrationCondition" type="auc:EquipmentCondition" minOccurs="0"/> |
There was a problem hiding this comment.
Hey Mark, is there a justification of choosing to add specific XXXCondition for every system over using the generic EquipmentCondition in your previous commit?
There was a problem hiding this comment.
To pass the tests, I followed the naming convention that was established for other "XXXCondition" elements.
JieXiong9119
left a comment
JieXiong9119
left a comment
There was a problem hiding this comment.
I recommend more consistent naming for EquipmentCondition elements, but let me know if there is a specific naming you would prefer unchanged.
PS: The HVACControlSystemCondition is a typo I believe.
JieXiong9119
left a comment
JieXiong9119
left a comment
There was a problem hiding this comment.
Made a slight change. All seem good to me!
| <xs:element ref="auc:LinkedPremises" minOccurs="0"/> | ||
| <xs:element ref="auc:UserDefinedFields" minOccurs="0"/> | ||
| <xs:element ref="auc:Quantity" minOccurs="0"/> | ||
| <xs:element name="HVACSystemCondition" type="auc:EquipmentCondition" minOccurs="0"/> |
There was a problem hiding this comment.
I think this should be HVACSystemCondition instead of HVACControlCondition
|
@markborkum Do you want to chat on more details on this PR or can we merge it directly? |
We can merge it. Thanks, @JieXiong9119. |
|
merging this |
Any background context you want to provide?
See proposal.
What does this PR do?
See proposal.
How should this be manually tested?
See proposal.
What are the relevant tickets?
N/A
Screenshots (if appropriate)
N/A