Skip to content

Conversation

@kflemin
Copy link
Contributor

@kflemin kflemin commented Aug 12, 2025

Proposal only

@kflemin kflemin added the feature Adding new functionality to BuildingSync label Aug 12, 2025
@kflemin kflemin added enhancement Schema: General General update to BuildingSync Non-breaking Change and removed feature Adding new functionality to BuildingSync labels Aug 21, 2025
Copy link

@supriyagoel supriyagoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kflemin is the plan to support multiple buildings in a facility in a single BSync or will each building be an individual BSync?
If the former, then the facility level parameters (agency, subagency, federal facility) should probably be defined at the site level. in either case, even if each building would be a separate BSync, would it make sense to have these defined at the site level?

@kflemin
Copy link
Contributor Author

kflemin commented Aug 21, 2025

Hi @supriyagoel, all of the use cases I have seen have a single building in a buildingsync file. The element currently already existed at the at the Building level: https://buildingsync.net/dictionary/2.6.0/#72175. I just added a few elements to this existing FederalBuilding element. If you think it is important to move this element to the site level, however, I can do that. It will just be a bigger change (and a breaking change to the current schema). would you still want this definable at the site and building levels, or just at the site level? thanks for reviewing!

@supriyagoel
Copy link

@kflemin I see- I did not realize federal building was already a data element. We definitely do not want to cause a breaking change- i think its good as is. Appreciate the response

* `auc:SubAgency` - Sub Agency according to agency's organizational structure. For CERL's workflow, this would be "Army".
* `auc:SubAgencySubLevel1` - Sub Agency Sub Level 1 represents another level down in the agency's organizational structure. For CERL's workflow, this would be the "Accountable Organization".
* `auc:SubAgencySubLevel2` - Sub Agency Sub Level 2 represents another level down in the agency's organization structure. For CERL's workflow this would be the "Accountable Sub Organization".
* `Facility` - Federal Facility represents another level down in the agency's organization structure. For CERL's workflow, this would be the "Installation".
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this be a duplicated name with the existing Facility element?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, I'll rename it to "FederalFacility"

Copy link
Contributor

@JieXiong9119 JieXiong9119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. FacilityNumber and PrimaryCategoryCode are treated as ID-like string for now.

<xs:documentation>Federal sub agency, according to organizational structure of the specified agency.</xs:documentation>
</xs:annotation>
</xs:element>
<xs:element name="SubAgencySubLevel1" type="xs:string" minOccurs="0">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kflemin Do you think we want to structure these SubLevel thingy in the way of parent/child? Something like:
Agency/SubAgency/SubAgencySbuLevel1?
I'm a bit concerned if there is request to restructure the current plain list there would be breaking changes in the future.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JieXiong9119 and I discussed and we will leave as a flat list to support as many agencies as possible

@kflemin
Copy link
Contributor Author

kflemin commented Sep 3, 2025

For reference: Screenshot 2025-09-03 at 10 34 46 AM

@kflemin kflemin merged commit f33a0f2 into develop-v2 Sep 3, 2025
3 checks passed
@kflemin kflemin deleted the cerl-proposal branch September 3, 2025 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants