Skip to content

Conversation

@leonluc-dev
Copy link

Updated for compatibility with new TypeInfo Reflection API, used in new
.NET environments like Windows Phone 8.1 , Apps for Windows Store and
their respective PCL profiles.

Updated for compatibility with new TypeInfo Reflection API, used in new
.NET environments like Windows Phone 8.1 and Apps for Windows Store and
their respective PCL profiles.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why implement CopyProperties? Properties are just setter and getter functions with underlying fields in a different syntax. Those underlying fields should already be copied in the CopyFields() method.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was actually a oversight on my part. I have corrected this in my latest commit.

CopyProperties method has been removed because underlying property
values are copied by the CopyField methods.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants