-
Notifications
You must be signed in to change notification settings - Fork 59
Create signature for DLL sideloading #504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kevross33
wants to merge
1
commit into
CAPESandbox:master
Choose a base branch
from
kevross33:patch-84
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| # Copyright (C) 2025 Kevin Ross | ||
| # | ||
| # This program is free software: you can redistribute it and/or modify | ||
| # it under the terms of the GNU General Public License as published by | ||
| # the Free Software Foundation, either version 3 of the License, or | ||
| # (at your option) any later version. | ||
| # | ||
| # This program is distributed in the hope that it will be useful, | ||
| # but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| # GNU General Public License for more details. | ||
| # | ||
| # You should have received a copy of the GNU General Public License | ||
| # along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
|
|
||
| from lib.cuckoo.common.abstracts import Signature | ||
|
|
||
| class DLLLoadSuspiciousDirectory(Signature): | ||
| name = "dllload_suspicious_directory" | ||
| description = "A DLL was loaded from a suspicious directory" | ||
| severity = 2 | ||
| confidence = 50 | ||
| categories = ["side loading"] | ||
| authors = ["Kevin Ross"] | ||
| minimum = "1.3" | ||
| evented = True | ||
| enabled = True | ||
| ttps = ["T1574"] # MITRE v6,7,8 | ||
| mbcs = ["F0015"] | ||
|
|
||
| def __init__(self, *args, **kwargs): | ||
| Signature.__init__(self, *args, **kwargs) | ||
| self.ret = False | ||
| # Any exclusions added to this list needs to be in lower format. | ||
| self.ignore_directories = [ | ||
| "c:\\windows\\system32\\", | ||
| "c:\\windows\\syswow64\\", | ||
| "c:\\windows\\", | ||
| "c:\\windows\\winsxs\\", | ||
| "c:\\program files\\", | ||
| "c:\\program files (x86)\\", | ||
| "c:\\programdata\\", | ||
| ] | ||
|
|
||
| filter_apinames = set(["DllLoadNotification"]) | ||
|
|
||
| def on_call(self, call, process): | ||
| if not call["status"]: | ||
| return None | ||
|
|
||
| if call["api"] == "DllLoadNotification": | ||
| notificationreason = self.get_argument(call, "NotificationReason") | ||
| dllname = self.get_argument(call, "DllName") | ||
| if notificationreason == "load": | ||
| pname = process["process_name"].lower() | ||
| dllnamelower = dllname.lower() | ||
| is_ignored = any(dllnamelower.startswith(d) for d in self.ignore_directories) | ||
| if not is_ignored: | ||
| self.mark_call() | ||
| self.data.append({"suspicious_dll_load": "Process %s loaded a DLL from a suspicious directory, this is possibly indicative of DLL side loading/search order hijacking" % (pname)}) | ||
| self.ret = True | ||
|
|
||
| def on_complete(self): | ||
| return self.ret | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good signature. I have a few suggestions to simplify the code and make the report more informative:
if call["api"] == "DllLoadNotification":check inon_callis redundant becausefilter_apinamesis set. This check can be removed.dllname.self.retflag is redundant. The signature's status can be determined by checking ifself.datais populated inon_complete.Here is a refactored version of the class with these changes applied.