Update network_dns_suspicious.py

[cccs-mog]

Necessary in order to actually hit on the actual domains, the point need to be escaped or it can be any character. Also the domain need to be finishing there so it is not as a subdomain or else it is not a shortener. This should be a domain not an URI so no issue for this.

[gemini-code-assist]

Summary of Changes

Hello @cccs-mog, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the accuracy of the NetworkDNSURLShortener signature by refining the regular expressions used to detect suspicious DNS shortener domains. The changes ensure that domain matching is more precise, preventing unintended matches with subdomains or incorrect character interpretations, thereby improving the reliability of the security detection mechanism.

Highlights

• Improved Domain Matching Accuracy: The regular expressions used for identifying suspicious DNS shortener domains have been updated to ensure more precise matching. This involves escaping periods and anchoring the patterns to the end of the string.
• Regular Expression Refinements: Periods ('.') in the domain indicators are now escaped ('.') to match literal dots, preventing them from matching any character. Additionally, the end-of-string anchor ('$') has been added to most patterns to ensure that only full domain matches are considered, avoiding false positives from subdomains.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request aims to improve the accuracy of URL shortener detection by converting domain strings to more precise regular expressions. This is a valuable change. I've found one pattern that was only partially updated and have left a specific comment for it. I also noticed that the pattern for ux9.de was missed entirely. While I cannot comment on it directly as it's not in the changed lines of the diff, I recommend applying the same regex conversion to it for consistency and to fully achieve the goal of this PR.