-
Notifications
You must be signed in to change notification settings - Fork 59
Add antivm_display signature #520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add signature to detect use of EnumDisplayDevices such as in Pikabot (https://capesandbox.com/analysis/41245/#)
Summary of ChangesHello @kevross33, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new anti-virtual machine signature designed to identify malware that attempts to detect its execution environment by querying display devices. By adding this detection capability, the system can better identify and flag suspicious activities, particularly those employed by sophisticated threats like Pikabot, thereby improving overall threat intelligence and analysis. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a new Cuckoo signature, antivm_display, to detect anti-VM techniques that involve querying display devices using EnumDisplayDevicesA or EnumDisplayDevicesW. The implementation is sound, but I have provided a couple of suggestions to improve consistency with other signatures in the project and to simplify the code. My recommendations include renaming the signature and class for consistency, increasing the severity to match similar checks, and refactoring the implementation to use a more standard pattern for evented signatures.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Add signature to detect use of EnumDisplayDevices such as in Pikabot (https://capesandbox.com/analysis/41245/#)