Fix CUDA 13 API compatibility for PeerUtils#20
Open
ryanorendorff wants to merge 1 commit intoCAPS-UMU:mainfrom
Open
Fix CUDA 13 API compatibility for PeerUtils#20ryanorendorff wants to merge 1 commit intoCAPS-UMU:mainfrom
ryanorendorff wants to merge 1 commit intoCAPS-UMU:mainfrom
Conversation
CUDA 13 added a `cudaGraphEdgeData*` parameter to the graph dependency and stream capture APIs. Add compat shims that present the CUDA 12 signature and pass nullptr for the new parameter on 13+, allowing the same source to compile against both versions. Tested on RTX 5090 with CUDA 12.6 (sm_90) and CUDA 13 (sm_120).
ryanorendorff
force-pushed
the
fix/scalar-encoding-flexibleautoext
branch
from
cc9ebd0 to
776d4dd
Compare
ryanorendorff
changed the title
Collaborator
|
Hello. This seems to be a nice patch. As we have just published some bugfixes I will need to do some conflict resolving and after some checks we'll be able to merge this. Thanks for your contribution, we are very keen on having CUDA 13 support. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CUDA 13 added a
cudaGraphEdgeData*parameter to the graph dependency and stream capture APIs (cudaGraphAddDependencies,cudaGraphNodeGetDependencies,cudaGraphNodeGetDependentNodes,cudaStreamGetCaptureInfo,cudaStreamUpdateCaptureDependencies). This broke compilation on sm_120 targets.This PR adds compat shims in
PeerUtils.cuthat present the CUDA 12 signature and passnullptrfor the new parameter on CUDA 13+, allowing the same source to compile against both versions.Tested on RTX 5090 with CUDA 12.6 (sm_90) and CUDA 13 (sm_120).