Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a clickability issue with the navigation button on small screens by addressing pointer event handling in overlapping elements.
Changes:
- Modified CSS styling to prevent click-blocking by an absolutely positioned div
- Converted padding to margin for proper spacing while enabling pointer event pass-through
- Added pointer event controls to allow clicks through empty space while preserving functionality on content
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
The nav button on small screens had issue being clickable. This ended up due to an absolute positioned div on top blocking the clicks due to overlap.
Change Details (Specifics)
The fix has been made by switching the empty space from padding to margin. And then making the parent div not have pointer-events, allowing us to click through the empty space. (this parent div is positioned absolutely causing this issue - I am not changing the existing styling since that is out of scope).
Related Ticket(s)
INS-1529