Skip to content

INS-1461 Setup Unit Testing Framework#151

Merged
amattu2 merged 16 commits into3.2.0from
unit-test
Dec 15, 2025
Merged

INS-1461 Setup Unit Testing Framework#151
amattu2 merged 16 commits into3.2.0from
unit-test

Conversation

@amattu2
Copy link
Contributor

@amattu2 amattu2 commented Dec 10, 2025

Overview

This PR introduces unit testing workflows to the INS backend.

Change Details (Specifics)

  • Add unit testing pipeline for the backend
  • Remove legacy/failing tests
  • Add consistent PR template
  • Add Jacoco dependency for test coverage

Related Ticket(s)

INS-1461

@amattu2 amattu2 marked this pull request as ready for review December 15, 2025 15:48
Copilot AI review requested due to automatic review settings December 15, 2025 15:48
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@amattu2
Copy link
Contributor Author

amattu2 commented Dec 15, 2025

@copilot To test the unit testing setup, I need unit tests written for the IndexController (gov.nih.nci.bento) functionality. Write unit tests that confirm that endpoint works as expected. Do not modify core code, only write new unit tests.

Copy link

Copilot AI commented Dec 15, 2025

@amattu2 I've opened a new pull request, #157, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot AI and others added 2 commits December 15, 2025 16:15
Co-authored-by: amattu2 <38357871+amattu2@users.noreply.github.com>
Co-authored-by: amattu2 <38357871+amattu2@users.noreply.github.com>
Copilot AI and others added 2 commits December 15, 2025 16:42
Co-authored-by: amattu2 <38357871+amattu2@users.noreply.github.com>
INS-1461 Add IndexController unit tests
@amattu2 amattu2 temporarily deployed to ccdi-manager-nonprod December 15, 2025 16:50 — with GitHub Actions Inactive
Copilot AI review requested due to automatic review settings December 15, 2025 16:55
@amattu2 amattu2 merged commit 6601b08 into 3.2.0 Dec 15, 2025
1 of 2 checks passed
@amattu2 amattu2 deleted the unit-test branch December 15, 2025 16:56
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

run: mvn test

- name: Coveralls GitHub Action
uses: coverallsapp/github-action@v2
Copy link

Copilot AI Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Coveralls GitHub Action needs to be configured to use the JaCoCo coverage report format. By default, it looks for LCOV format, but JaCoCo generates XML reports. You should add the 'format' parameter set to 'jacoco' to ensure the coverage report is properly parsed.

Suggested change
uses: coverallsapp/github-action@v2
uses: coverallsapp/github-action@v2
with:
format: jacoco

Copilot uses AI. Check for mistakes.
- "*"

permissions:
contents: read
Copy link

Copilot AI Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workflow needs write permissions for pull-requests to allow the Coveralls action to post comments on PRs. Consider adding 'pull-requests: write' to the permissions section to enable coverage report comments on pull requests.

Suggested change
contents: read
contents: read
pull-requests: write

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants