Conversation
michael-fleming
suggested changes
May 12, 2023
michael-fleming
left a comment
There was a problem hiding this comment.
can we make the following changes:
- for all builds can we use "{{ container_build_path }}" for the path parameter - this will make the code more adaptable
- for the frontend build can we delete the commented build steps. we won't be using these going forward so we won't need to keep them to uncomment them
- can we add the trivy scanning steps for all of the builds. this should match what is done in the backend build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modified bento backend