Skip to content

Update endpoint for testing fhir server connections #671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

katyasoup
Copy link
Collaborator

PULL REQUEST

Summary

Updates the "test connection" on the FHIR server config page to check the /metadata endpoint, rather than /Patient. This endpoint returns a Capability Statement that does not require Patient identifiers to be present on the request.

Related Issue

Fixes #670

Additional Information

Anything else the review team should know?

Checklist

  • Descriptive Pull Request title
  • Link to relevant issues
  • Provide necessary context for design reviewers
  • Ensure test coverage is above agreed upon threshold
  • Update documentation

Copy link

linear bot commented Jun 2, 2025

@codecov-commenter
Copy link

codecov-commenter commented Jun 2, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 64.73%. Comparing base (a7bb221) to head (bc5f377).

Files with missing lines Patch % Lines
src/app/shared/fhirClient.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #671   +/-   ##
=======================================
  Coverage   64.73%   64.73%           
=======================================
  Files         113      113           
  Lines        5521     5521           
  Branches     1308     1331   +23     
=======================================
  Hits         3574     3574           
  Misses       1935     1935           
  Partials       12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nickclyde
Copy link
Member

Okay so this is a tricky one, because we want to be able to test a proper authentication with "Test connection", but I think typically /metadata is an unauthenticated endpoint. Let me look around to see if there is a better option of an endpoint to hit, open to suggestions as well.

fzhao99
fzhao99 previously approved these changes Jun 3, 2025
@fzhao99 fzhao99 dismissed their stale review June 3, 2025 12:47

read Nick's comment

@katyasoup katyasoup force-pushed the kcd/que-307-update-test-connection-endpoint branch from c72e65b to 0570387 Compare June 5, 2025 17:13
@katyasoup katyasoup force-pushed the kcd/que-307-update-test-connection-endpoint branch from c7c64d6 to 439170a Compare June 5, 2025 17:15
@katyasoup
Copy link
Collaborator Author

@nickclyde @fzhao99 I added back the /Patient endpoint, but threw in a dummy string for the name param - expected result is bundle response with 0 resources. Should all be working now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow empty patient identifiers when testing server connections
5 participants