This repository was archived by the owner on Apr 30, 2024. It is now read-only.
Merged the frictionlessdata/components into local upstream-merge branch #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Bootstrapped Schema * Added schema styles * Added schema dependencies * Added SchemaFeedback * Added SchemaPreview * Added SchemaField * Added Schema * Added schema helpers * Ignored fs module * Fixed schema editor error * Fixed Field update/remove * Fixed the preview * Fixed the Details button * Fixed styles * Fixed sorting * Removed debug * Fixed visual sorting * Added a story with source
…rictionlessdata#18) * On schema change (#1) * prop to disable save tab * add onSchemaChanged handler in a useEffect based on columns and meta * run prettier Co-authored-by: Igor Strupinskiy <istrupinskiy@clearwateranalytics.com> * On schema change (#2) * prop to disable save tab * add onSchemaChanged handler in a useEffect based on columns and meta * run prettier * make disableSave optional Co-authored-by: Igor Strupinskiy <istrupinskiy@clearwateranalytics.com> * greater than 17.0.0 react peer dep * On schema change (#3) * prop to disable save tab * add onSchemaChanged handler in a useEffect based on columns and meta * run prettier * make disableSave optional * rename onSchemaChanged to onSchemaChange Co-authored-by: Igor Strupinskiy <istrupinskiy@clearwateranalytics.com> Co-authored-by: Igor Strupinskiy <istrupinskiy@clearwateranalytics.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merged upstream version 1.2.0 into upstream-merge branch locally. This is a PR for merging that merge into our main branch. There were a number of merge conflicts which I needed to sort out. I already had to tag and upload to npm for testing since we pull it in from npm.
I tested some within our application. We are no longer getting the errors we originally got when we updated the python frictionless libraries. Frictionless using 4.38.0 works with the "components" repo.
Tested with some files that produced problems and they seem to display ok still.