Local testing #146
Open
Local testing #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is not the most semantically correct, but it doesn't break anything and orchid seems to expect it
this is necessary to make this sort of query work
This was
linked to
issues
Nov 26, 2024
This was referenced Dec 19, 2025
Closed
techgique
requested changes
Dec 20, 2025
Member
techgique
left a comment
techgique
left a comment
There was a problem hiding this comment.
Noting what I found before I work on the code to make revisions.
- Make auth code more readable with less string interpolation and separate multiple args for methods across lines - Check if elasticsearch credentials are present to determine whether to construct addition auth header and merge with json header
- Compare and match against a fresh `rails new --api` app - Remove net-smtp gem from Gemfile and Changelog - Remove extra platforms
Remove old new_framework_defaults initializers for 5.0 and 5.2
Update of Gemfile required logger be added to boot.rb now Listen gem version was causing Rails app boot to fail. Hadn't run bundle update again after removing the extra platforms, so suspect this was the problem we'd seen before with those 🤔
Note production is modified to keep non-public production domains out of source control
Add back RestClient::BadRequest exception so both display errors from Elasticsearch in API response rather than returning an opaque Rails error page
- Fix typo in comment - Reformat other comments so there is a space between # and text - Refactor `if nested` code together and bypass extraneous variable when value only used once after - Likewise for path variable - Fix indentation of aggregation hash
- Remove extraneous returns - Remove extraneous use of buckets variable when direct returns work
- Version to 2.0.0
- Config example license and docs links updated. Old year removed from
`api_update` example
- Changelog review
- Set version for release and compare url to `v2.0.0`
- Change explicit code references to `code` rather than "quotes"
- Capitalize first words, remove trailing periods
- Remove duplicate entries (`Migration` section, `api_version` added
to `res`)
- Drop Rails and Ruby entry as v1.0.5 for v1 already upgraded to them
- Move text for list item including json snippets to before
the snippets as Markdown doesn't connect the indented text after
with prior list items
- Add json syntax highlighting to json snippets
- Reorder some of the major change items to the top of sections
- Add v1.0.5 release that was forgotten with that release
Resolve merge conflicts - Keep all changes from `local_testing` for Changelog, Gemfile, Gemfile.lock - Others accepted from `dev`
techgique
approved these changes
Dec 20, 2025
Member
|
@wkdewey, please review the changes I've made to double-check I haven't made any mistakes. We might want to test this on the dev server with the dev Rails apps utilizing it as well. The changes I made to handle Elasticsearch both with and without auth mean we can delete the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
contains all the work I've been doing on the API (see #128 which this supercedes)