[WIP] Dissolution of porous media model #391
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mdzik
commented
Apr 27, 2022
mdzik
commented
- based on Stokes TRT collision for Flow
- reaction-diffusion model, with TRT, is included by new
- this is indended as 3D model, 2D is not tested
- for some demo see: https://github.com/mdzik/TCLB_Workshop_2021/blob/main/workshops/90_StokesBrinkmanPermability/ReactiveStokeBrinkmanTesting.ipynb
- known Issue: ADRE is overshooting for low diffusivity
…ffusion_configurable
| D3Q19 = TRUE | ||
| QIntegrator = 'Heun' | ||
| #QIntegrator = 'Trapezoid' | ||
| source("../models/reaction/d2q9_reaction_diffusion_system/Dynamics.R") |
Member
There was a problem hiding this comment.
source("../models/reaction/d2q9_reaction_diffusion_system/Dynamics.R")
:-)
|
|
||
|
|
||
| // This should go at the end to avoid name conflicts in R | ||
| <?RT models/reaction/d2q9_reaction_diffusion_system/Dynamics.c.Rt ?> |
Member
There was a problem hiding this comment.
odels/reaction/d2q9_reaction_diffusion_system/Dynamics.c.Rt expects a DoADRE_CalcPhi functions
llaniewski
requested changes
Oct 9, 2023
Member
llaniewski
left a comment
llaniewski
left a comment
There was a problem hiding this comment.
@mdzik How this is progressing? Do you have a newer version of the model you would want to merge?
Can you clean it up:
- there is a binary a.out file commited,
- the test file is mostly commented out.
Member
|
@mdzik This is hanging here for a long time. Are you still working on this? Do you think it will be a thing to merge soon? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.