Enhance world #46
Draft
Enhance world #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Main difference is that now the game uses protobuf-net package instead of XMLSerializer. Still has bugs: won't load world from menu, group id 0, null value in EventGenerators... BUT, save/load times are under 10 seconds from over 60 seconds.
Biome.Biomes was null on world load and would cause a null pointer exception when using Biome.Biomes.count since it didn't exist yet. EventMessageIds would have a single event with id=0 due to initialization? I'm not really certain where it comes from, but for now I have placed a check before it gets enumerated in world load. Also added protobuf-net implementation due all EventMessages since last time I did not. I have also been removing unused directives so that the namespace is cleaner and compile time increases very slightly. Restructured the [ProtoInclude] hierarchy for WorldEvent so that each subtype can be called correctly. Current bugs: When loading a world from the main menu, it succeeds but the game is non-interactive with a semi-transparant gray screen over the world scene. I have no idea why.
…ready been removed
also, removed some unnecessary Floor() operations
Debugging core distances
transfer in additions and compatible edits from "enhanced save" to here. Well, compatibility is unknown, will have to test. But, still.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
transfer in the enhanced world generation into the "culture" branch