Skip to content

Conversation

@JordanLaserGit
Copy link
Collaborator

@JordanLaserGit JordanLaserGit commented Nov 13, 2025

This PR removes the LSTM conus download from the community resources and instead implements lstm bmi config generation from the geopackage.

Additions

gen_lstm() in src/datastreamcli/ngen_configs_gen.py
test_lstm_v22() in tests/test_bmi_config_generation.py

Removals

Changes

I did edit noahowp_pkl.py (and related test) to avoid passing a global variable which breaks on MacOS.

Testing

  1. tests/test_bmi_config_generation.py

Screenshots

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

  • Windows
  • Linux
  • MacOS

Accessibility

  • Keyboard friendly
  • Screen reader friendly

Other

  • Is useable without CSS
  • Is useable without JS
  • Flexible from small to large screens
  • No linting errors or warnings
  • JavaScript tests are passing

@JordanLaserGit JordanLaserGit self-assigned this Nov 18, 2025
@JordanLaserGit JordanLaserGit added the enhancement New feature or request label Nov 18, 2025
@JordanLaserGit JordanLaserGit added the NRDS LSTM AWS Related to the NRDS deployment of the LSTM datastream in AWS label Nov 18, 2025
@JordanLaserGit
Copy link
Collaborator Author

The options workflow is failing due to an error addressed in #28

@JordanLaserGit JordanLaserGit moved this from In Progress to Done in NextGen Research Datastream (NRDS) Nov 20, 2025
@arpita0911patel arpita0911patel requested review from JoshCu and benlee0423 and removed request for arpita0911patel and harshavemula-ua November 25, 2025 19:53
Comment on lines +199 to +202
lstm_config_jcat['elev_mean'] = attrs_row['mean.elevation']
lstm_config_jcat['lat'] = lat
lstm_config_jcat['lon'] = lon
lstm_config_jcat['slope_mean'] = attrs_row['mean.slope']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you might want to check the values in the hydrofabric you're using, for the v2.2 conus hydrofabric and by extension the community hydrofabric too elevation is actually in cm and I had to convert the slope like this too https://github.com/CIROH-UA/NGIAB_data_preprocess/blob/36b8f0a8dd77462aae3d33c9e93385103637cf98/modules/data_processing/create_realization.py#L149C5-L172C14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request NRDS LSTM AWS Related to the NRDS deployment of the LSTM datastream in AWS

Projects

Development

Successfully merging this pull request may close these issues.

Add rust-lstm functionality in datastreamcli

3 participants