-
Notifications
You must be signed in to change notification settings - Fork 5
add lstm bmi config gen feature with test #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…reamcli into gen_lstm_configs
|
The options workflow is failing due to an error addressed in #28 |
| lstm_config_jcat['elev_mean'] = attrs_row['mean.elevation'] | ||
| lstm_config_jcat['lat'] = lat | ||
| lstm_config_jcat['lon'] = lon | ||
| lstm_config_jcat['slope_mean'] = attrs_row['mean.slope'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you might want to check the values in the hydrofabric you're using, for the v2.2 conus hydrofabric and by extension the community hydrofabric too elevation is actually in cm and I had to convert the slope like this too https://github.com/CIROH-UA/NGIAB_data_preprocess/blob/36b8f0a8dd77462aae3d33c9e93385103637cf98/modules/data_processing/create_realization.py#L149C5-L172C14
This PR removes the LSTM conus download from the community resources and instead implements lstm bmi config generation from the geopackage.
Additions
gen_lstm()in src/datastreamcli/ngen_configs_gen.pytest_lstm_v22()in tests/test_bmi_config_generation.pyRemovals
Changes
I did edit noahowp_pkl.py (and related test) to avoid passing a global variable which breaks on MacOS.
Testing
Screenshots
Notes
Todos
Checklist
Testing checklist
Target Environment support
Accessibility
Other