fix(js): avoid false tool-call capture on plain tool_calls prose#168
Merged
CJackHwang merged 5 commits intodevfrom Mar 30, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6efba7b2e4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
CJackHwang
added a commit
that referenced
this pull request
Mar 30, 2026
Merge pull request #168 from CJackHwang/codex/fix-vercel-deployment-issue-with-api-calls fix(js): avoid false tool-call capture on plain tool_calls prose
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
tool_calls) appeared in normal prose, causing the client stream to appear truncated after the keyword.tool_callsfrom being misdetected as the start of a tool-call JSON payload.Description
internal/js/helpers/stream-tool-sieve/sieve.jsso capture only starts when there is an actual{before a matched tool keyword (change infindToolSegmentStart).tests/node/stream-tool-sieve.test.js(new case: "sieve does not start capture on plain "tool_calls" prose without opening json brace") to ensure plain mentions are preserved as text.fix(js): avoid false tool-call capture on plain tool_calls proseand included the updated filesinternal/js/helpers/stream-tool-sieve/sieve.jsandtests/node/stream-tool-sieve.test.js.Testing
bash tests/scripts/run-unit-node.sh, all JS tests passed (48/48).bash tests/scripts/run-unit-go.sh, all Go unit tests passed (cached/ok results shown).go run ./cmd/ds2api-tests --config /tmp/ds2api-live-config.json --admin-key admin --no-preflight --timeout 90 --retries 1 --keep 1; tool-related streaming cases passed and overall live run produced 28 passed / 2 failures that are unrelated to this fix (embeddings_contractanderror_contract_invalid_model).Codex Task