Enable env-backed config writeback and bootstrap missing config file#171
Merged
CJackHwang merged 5 commits intodevfrom Mar 30, 2026
Merged
Enable env-backed config writeback and bootstrap missing config file#171CJackHwang merged 5 commits intodevfrom
CJackHwang merged 5 commits intodevfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f3555ae9b0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
CJackHwang
added a commit
that referenced
this pull request
Mar 30, 2026
Merge pull request #171 from CJackHwang/codex/fix-issue-#170-in-ds2api Enable env-backed config writeback and bootstrap missing config file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
DS2API_CONFIG_JSONenv var to be persisted to disk when desired and to bootstrap a missing config file so runtime changes are not lost, while still preserving special-case behavior for Vercel.Description
envWritebackEnabled()to recognizeDS2API_ENV_WRITEBACKtruthy values and update imports to includefmtandpath/filepath.loadConfig()to, whenDS2API_CONFIG_JSONis present and writeback is enabled (and not Vercel), prefer an existing file-backed config if present and attempt to write a bootstrap file when the config path does not exist.Store.Save()andstore.saveLocked()to persist an env-backed store when writeback is enabled by callingwriteConfigBytes()and clears.fromEnvafter a successful write, while retaining the previous skip behavior for Vercel or when writeback is disabled.writeConfigFile()andwriteConfigBytes()to marshal configs, create parent directories withos.MkdirAll, and write files safely.TestEnvBackedStoreWritebackBootstrapsMissingConfigFileto verify bootstrapping from env JSON and subsequent persistence and reload semantics.Testing
go test ./internal/config -run TestEnvBackedStore*, which executed the newTestEnvBackedStoreWritebackBootstrapsMissingConfigFileand related tests, and they passed.go test ./...to ensure no regressions in other packages, and all tests passed.Codex Task