Skip to content

Conversation

@JamesDemeryNava
Copy link
Contributor

JIRA Ticket:
BB2-4395

What Does This PR Do?

Updates the request library to 2.32.5 from 2.32.2. Also ensures selenium tests will pass (using a suggestion from @jadudm), after a change to the UI was made that caused seven of the nine tests to fail.

What Should Reviewers Watch For?

  • Has the library been updated correctly? Are there any requirements files that were not updated?

If you're reviewing this PR, please check for these things in particular:

Validation

  • Ensure selenium tests pass
  • Go through auth flow for v2 and v3 in the testclient, run the different requests there. Do they return successfully?
  • In your local logs, do you see "req_header_user_agent": "python-requests/2.32.5"? Previously would've been "req_header_user_agent": "python-requests/2.32.2"

What Security Implications Does This PR Have?

Please indicate if this PR does any of the following:

  • Adds any new software dependencies
  • Modifies any security controls
  • Adds new transmission or storage of data
  • Any other changes that could possibly affect security?
  • Yes, one or more of the above security implications apply. This PR must not be merged without the ISSO or team
    security engineer's approval.

Any Migrations?

  • Yes, there are migrations
    • The migrations should be run PRIOR to the code being deployed
    • The migrations should be run AFTER the code is deployed
    • There is a more complicated migration plan (downtime,
      etc)
  • No migrations

Copy link
Contributor

@jadudm jadudm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates library in requirements, passes tests, LGTM.

@JamesDemeryNava JamesDemeryNava merged commit 9861cfa into master Jan 28, 2026
8 checks passed
@JamesDemeryNava JamesDemeryNava deleted the jamesdemery/bb2-4395-update-requests-library branch January 28, 2026 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants