Add alerts for estimated amount in v3.0, nine 9s in allowed amount elements#89
Merged
shaselton-usds merged 4 commits intomainfrom Feb 6, 2026
Merged
Add alerts for estimated amount in v3.0, nine 9s in allowed amount elements#89shaselton-usds merged 4 commits intomainfrom
shaselton-usds merged 4 commits intomainfrom
Conversation
The estimated amount property was removed from the data dictionaries in version 3.0. Show an alert if a CSV column header is found that would match that property's definition. Show an alert if a payers information object in JSON contains an estimated amount property. Do not show alerts for versions prior to 3.0.
Emit an alert when validating a file on version 3.0.0 or later and a value of nine 9s is encoded for median amount, 10th percentile, or 90th percentile.
daniel-eckel
approved these changes
Feb 5, 2026
| @@ -0,0 +1,54 @@ | |||
| { | |||
Collaborator
There was a problem hiding this comment.
I'm still impressed/loving this sub-schema implementation check!
shaselton-usds
approved these changes
Feb 6, 2026
Collaborator
shaselton-usds
left a comment
shaselton-usds
left a comment
There was a problem hiding this comment.
Pulled down, ran test locally -- looks great.
Is there an alert limit that can be pushed the array?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The estimated amount property was removed from the data dictionaries in version 3.0. If validating a file with version 3.0 or later, show an alert if a CSV column header is found that would match that property's definition, and show an alert if a payers information object in JSON contains an estimated amount property. Do not show these alerts for versions prior to 3.0.
Emit an alert when validating a file on version 3.0.0 or later and a value of nine 9s is encoded for count, median amount, 10th percentile, or 90th percentile.