[SEVERE] fix: failed to build dependency imgui with latest Clang 21 on MacOS 26.3.1#36
Open
XDflight wants to merge 1 commit intoCMU-Graphics:mainfrom
Open
[SEVERE] fix: failed to build dependency imgui with latest Clang 21 on MacOS 26.3.1#36XDflight wants to merge 1 commit intoCMU-Graphics:mainfrom
imgui with latest Clang 21 on MacOS 26.3.1#36XDflight wants to merge 1 commit intoCMU-Graphics:mainfrom
Conversation
… 26.3.1 Ported upstream fix ocornut/imgui@88e2327.
There was a problem hiding this comment.
Pull request overview
Ports an upstream Dear ImGui fix to restore successful builds with the latest Clang 21 on macOS by suppressing a new warning that is treated as an error in this repo.
Changes:
- Suppress Clang’s
-Wnontrivial-memaccesswarning across multiple ImGui translation units/headers. - Align warning-suppression blocks in ImGui sources to avoid build breaks under
-Werroron newer toolchains.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| deps/imgui/imgui_widgets.cpp | Ignore -Wnontrivial-memaccess in the Clang warning-suppression block. |
| deps/imgui/imgui_tables.cpp | Ignore -Wnontrivial-memaccess in the Clang warning-suppression block. |
| deps/imgui/imgui_internal.h | Ignore -Wnontrivial-memaccess in the Clang warning-suppression block. |
| deps/imgui/imgui_draw.cpp | Ignore -Wnontrivial-memaccess in the Clang warning-suppression block. |
| deps/imgui/imgui.h | Ignore -Wnontrivial-memaccess in the Clang warning-suppression block (needs guarding for older Clang). |
| deps/imgui/imgui.cpp | Ignore -Wnontrivial-memaccess in the Clang warning-suppression block. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ported upstream fix ocornut/imgui@88e2327.