Migrate to Java 25 (LTS) and Spring Boot 4.0.6#185
Open
devin-ai-integration[bot] wants to merge 1 commit intoDevOpsfrom
Open
Migrate to Java 25 (LTS) and Spring Boot 4.0.6#185devin-ai-integration[bot] wants to merge 1 commit intoDevOpsfrom
devin-ai-integration[bot] wants to merge 1 commit intoDevOpsfrom
Conversation
- Upgrade Spring Boot from 3.3.3 to 4.0.6 (Spring Framework 7.0) - Upgrade Java from 17 to 25 (latest LTS) - Fix maven-compiler-plugin: remove hardcoded source/target 1.8, use release flag - Update MySQL connector: mysql-connector-java -> com.mysql:mysql-connector-j - Remove deprecated MySQL8Dialect (Hibernate auto-detects dialect) - Update SecurityConfig for Spring Security 7: - Remove AntPathRequestMatcher (removed in SS7), use logoutUrl() - Remove configureGlobal (auto-detected via UserDetailsService bean) - Update Dockerfile to Eclipse Temurin 25 base images - Replace deprecated MAINTAINER with LABEL - Update Maven wrapper to 3.9.9 - Add H2 test dependency and test application.properties for testing Co-Authored-By: Joao Esteves <joao.esteves@cognition.ai>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates the project from Java 17 / Spring Boot 3.3.3 to Java 25 (latest LTS) / Spring Boot 4.0.6 (latest stable release, built on Spring Framework 7.0).
Changes
pom.xml:
3.3.3→4.0.6java.version:17→25source/targetof1.8(was inconsistent), now uses<release>${java.version}</release>mysql:mysql-connector-java:8.0.33→com.mysql:mysql-connector-j(old artifact deprecated; version managed by Spring Boot BOM)SecurityConfig.java (Spring Security 7.0 compatibility):
AntPathRequestMatcher(class removed in Spring Security 7); replaced withlogoutUrl("/logout")configureGlobal(AuthenticationManagerBuilder)method — Spring Security auto-discovers theUserDetailsServiceandPasswordEncoderbeansapplication.properties:
org.hibernate.dialect.MySQL8Dialect— Hibernate 7.x auto-detects the dialectDockerfile:
maven:3.8.3-openjdk-17→maven:3.9-eclipse-temurin-25openjdk:17-alpine→eclipse-temurin:25-jre-alpineMAINTAINERdirective withLABEL maintainer=...as→ASfor multi-stage build best practicesMaven wrapper: Updated from 3.9.7 to 3.9.9
Test infrastructure: Added
src/test/resources/application.propertieswith H2 in-memory database config for testsReview & Testing Checklist for Human
docker build -t bankapp .)Notes
source/targetset to1.8which was inconsistent with thejava.versionproperty of17— this has been correctedthymeleaf-extras-springsecurity6artifact name is retained as nospringsecurity7artifact has been published; the existing version is compatible with Spring Security 7.0Link to Devin session: https://app.devin.ai/sessions/652dbc1c843345eba40d0980eb4e0110
Requested by: @joao-cognition
Devin Review