Publish ftgo-common and ftgo-common-jpa as shared Maven artifacts#189
Open
devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
Open
Publish ftgo-common and ftgo-common-jpa as shared Maven artifacts#189devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
Conversation
Publish ftgo-common, ftgo-common-jpa, ftgo-consumer-service-api, and ftgo-restaurant-service-api as standalone Maven artifacts to GitHub Packages so extracted microservices can depend on them without needing the monolith source. - Add shared maven-publish plugin config in root build.gradle - Set version 1.0.0 on publishable modules for correct POM resolution - Project dependency ftgo-common-jpa -> ftgo-common resolves to net.chrisrichardson.ftgo:ftgo-common:1.0.0 in generated POM - Add README.md documenting artifact coordinates and usage Co-Authored-By: benc <Benc@windsurf.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
maven-publishplugin configuration so thatftgo-common,ftgo-common-jpa,ftgo-consumer-service-api, andftgo-restaurant-service-apican be published as standalone Maven artifacts to GitHub Packages. This enables future extracted microservices to depend on these shared modules via standard Maven coordinates (net.chrisrichardson.ftgo:<module>:1.0.0) without needing the monolith source.Approach: All publishing config is centralized in the root
build.gradleusing aconfigureblock that targets the four publishable modules by name. No individual modulebuild.gradlefiles were modified — existingcompile project(":ftgo-common")references continue to work unchanged for monolith builds.Key detail:
version = '1.0.0'is set at the project level on publishable modules so that Gradle resolves inter-project dependencies to proper Maven coordinates in generated POMs. Verified locally thatftgo-common-jpa's POM correctly declaresnet.chrisrichardson.ftgo:ftgo-common:1.0.0(notunspecified).Review & Testing Checklist for Human
version = '1.0.0'appears both asproject.versionand inside theMavenPublicationblock. Confirm this is acceptable or consolidate (e.g., useversion = project.versioninside the publication).versionon publishable subprojects: This changesproject.versionfromunspecifiedto1.0.0for these 4 modules. Verify no other build logic (e.g., jar naming, other plugins) is affected by this.""if env vars / gradle properties are missing. Consider whether publish should fail fast with a clear error instead.GITHUB_ACTOR=<user> GITHUB_TOKEN=<pat> ./gradlew :ftgo-common:publish :ftgo-common-jpa:publishagainst GitHub Packages to verify the full flow. OnlypublishToMavenLocalwas tested in this PR.net.chrisrichardson.ftgo:ftgo-common-jpa:1.0.0from GitHub Packages (or local Maven) and verify transitive deps resolve correctly.Notes
ftgo-end-to-end-tests-common(missingeventuate-util-testartifact) is unrelated to this change — the eventuate Maven repo was already commented out in the root build../gradlew publish).README.mdwas added documenting artifact coordinates, consumption instructions, and publish commands.Link to Devin session: https://app.devin.ai/sessions/315132c28df14cf18922fa23aff8e779
Requested by: @bcmake