Implement comprehensive unit test coverage (~86 test cases across all 5 phases)#190
Open
devin-ai-integration[bot] wants to merge 2 commits intomasterfrom
Open
Implement comprehensive unit test coverage (~86 test cases across all 5 phases)#190devin-ai-integration[bot] wants to merge 2 commits intomasterfrom
devin-ai-integration[bot] wants to merge 2 commits intomasterfrom
Conversation
…3, 4) Co-Authored-By: Toby Drinkall <toby.drinkall@cognition.ai>
… 5 cross-cutting tests - PlanTest: add/remove/filter actions for deliveries - AddressTest: creation with/without lat/lng, setter verification - ErrorResponseTest: field population and auto-timestamping - PersonNameTest: getter/setter for first/last name - ApiRequestLogTest: creation, completion with status, completion with error - ApiTrackingInterceptorTest: correlation ID generation/propagation, log persistence, error handling - GlobalExceptionHandlerTest: proper HTTP status codes for all 7 exception types - Fix ftgo-application build.gradle: add spring-boot-starter-test, exclude broken FtgoApplicationTest Co-Authored-By: Toby Drinkall <toby.drinkall@cognition.ai>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the full unit test plan from
UNIT_TEST_PLAN.md, adding comprehensive test coverage across all 5 phases:OrderTest,CourierTest,RestaurantTest,ConsumerTest,PlanTestAddressTest,ErrorResponseTest,PersonNameTestOrderServiceTest,ConsumerServiceTest,CourierServiceTest,RestaurantServiceTestOrderControllerTest(expanded),ConsumerControllerTest,CourierControllerTest,RestaurantControllerTestApiTrackingInterceptorTest,ApiRequestLogTest,GlobalExceptionHandlerTestAdditional changes:
build.gradle: Force resolution ofbyte-buddy1.14.12 andmockito-core4.11.0 for Java 17 compatibilityftgo-application/build.gradle: Addedspring-boot-starter-testdependency; excluded brokenFtgoApplicationTest(depends on defunct eventuate library)ftgo-domain/build.gradle: Addedmockito-corefor domain testsbuild.gradlefiles: Addedspring-boot-starter-testand RestAssured test dependenciesConsumerMother,CourierMother) for reusable test fixturesReview & Testing Checklist for Human
UNIT_TEST_PLAN.md./gradlew :ftgo-domain:test :ftgo-common:test :ftgo-order-service:test :ftgo-consumer-service:test :ftgo-courier-service:test :ftgo-restaurant-service:test :ftgo-application:test— all tests should passFtgoApplicationTestexclusion inftgo-application/build.gradleis acceptable (it was already broken due to missing eventuate dependency)Notes
byte-buddyandmockito-coreversions in rootbuild.gradleare needed because the project targets Java 8 but the build environment runs Java 17; older Mockito/ByteBuddy versions are incompatible with Java 17's module systemFtgoApplicationTest(integration test extendingAbstractEndToEndTests) was excluded from compilation because its dependency chain includesio.eventuate.util:eventuate-util-test:0.1.0.RELEASEwhich is no longer available (Bintray repos are defunct)Link to Devin session: https://app.devin.ai/sessions/c3c2605139c048d5a844b3454177c838
Requested by: @tobydrinkall
Devin Review