Task 8: Fix Hardcoded Credentials and Replace jcenter()#197
Open
devin-ai-integration[bot] wants to merge 2 commits intomasterfrom
Open
Task 8: Fix Hardcoded Credentials and Replace jcenter()#197devin-ai-integration[bot] wants to merge 2 commits intomasterfrom
devin-ai-integration[bot] wants to merge 2 commits intomasterfrom
Conversation
- docker-compose.yml: Replace hardcoded MySQL passwords with env var references using defaults - ftgo-flyway/build.gradle: Replace hardcoded Flyway credentials with env var references - build.gradle: Remove deprecated jcenter() repository (mavenCentral() already present) Co-Authored-By: Wes Convery <2wconvery@gmail.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Replace static schema.sql with init-db.sh shell script that reads MYSQL_USER at container startup, ensuring custom users get proper privileges on the ftgo database. Addresses Devin Review feedback about hardcoded username in GRANT. Co-Authored-By: Wes Convery <2wconvery@gmail.com>
Open
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses two security/maintenance concerns:
Hardcoded credentials replaced with environment variable references (with safe defaults for local dev):
docker-compose.yml: MySQL container passwords and ftgo-application datasource credentials now read from env vars (MYSQL_ROOT_PASSWORD,MYSQL_USER,MYSQL_PASSWORD) with fallback defaults.ftgo-flyway/build.gradle: Flywayuserandpasswordnow read fromFLYWAY_USERandFLYWAY_PASSWORDenv vars with fallback defaults.mysql/Dockerfile+mysql/init-db.sh: Replaced staticschema.sqlwith a shell script that readsMYSQL_USERat container startup for the GRANT statement, ensuring custom users get proper database privileges.Deprecated
jcenter()repository removed from rootbuild.gradle.mavenCentral()was already present and jcenter was sunset in 2021. The only otherjcenter()reference (inftgo-order-service/build.gradle) is already commented out.No functional changes — existing defaults preserve backward compatibility for local development.
Review & Testing Checklist for Human
docker-compose upstill works without setting any env vars (defaults should kick in)mavenCentral()aloneMYSQL_USER=customuser docker-compose up)Notes
Link to Devin session: https://app.devin.ai/sessions/63ae9590c93b48c19bde062e84cca2b2
Requested by: @WesternConcrete
Devin Review