Task 4: Replace Springfox with springdoc-openapi#199
Open
devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
Open
Task 4: Replace Springfox with springdoc-openapi#199devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
Conversation
- Remove springfox-swagger2 and springfox-swagger-ui dependencies - Add springdoc-openapi-ui:1.8.0 (compatible with Spring Boot 2.x) - Replace Docket/EnableSwagger2 configuration with GroupedOpenApi and OpenAPI beans - No changes needed to service configuration files (they only import CommonSwaggerConfiguration) Co-Authored-By: Wes Convery <2wconvery@gmail.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Open
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the deprecated Springfox Swagger 2 library with springdoc-openapi-ui 1.8.0 (compatible with the project's Spring Boot 2.x).
Changes:
common-swagger/build.gradle: Removedspringfox-swagger2:2.8.0andspringfox-swagger-ui:2.8.0dependencies; addedspringdoc-openapi-ui:1.8.0CommonSwaggerConfiguration.java: Replaced SpringfoxDocket/@EnableSwagger2configuration with springdocGroupedOpenApiandOpenAPIbeansNot changed (verified clean):
RestaurantServiceConfiguration.java— only importsCommonSwaggerConfiguration, no springfox-specific codeOrderServiceConfiguration.java— only importsCommonSwaggerConfiguration, no springfox-specific codeConsumerServiceConfiguration.java— only importsCommonSwaggerConfiguration, no springfox-specific codeBuild verification:
:common-swagger:buildpasses:ftgo-restaurant-service:compileJava,:ftgo-order-service:compileJava,:ftgo-consumer-service:compileJavaall compile successfullyspringfoxreferences anywhere in the codebaseReview & Testing Checklist for Human
/swagger-ui.htmlor/swagger-ui/index.htmlafter starting the application (springdoc serves UI at a different default path than springfox)/v3/api-docsand includes the expected endpoints under theftgogroupspringdoc.packagesToScancorrectly picks up all controller classes undernet.chrisrichardson.ftgoNotes
springdoc-openapi-starter-webmvc-uiinstead)eventuate-util-testfrom deprecated jcenter) is unrelated to these changesLink to Devin session: https://app.devin.ai/sessions/ceba4fdb13924d929e825b05c8bda18e
Requested by: @WesternConcrete
Devin Review